Odyssey 1.23 progress: r5 RC2

@samo
No needs for those verify-tests of course :) i done them myself already (see previous posts, and for odysseys, and for joerg's owb). And before you says "but i test it on sam, maybe it will be different" : nope, i already collect crashes from all the HW, they all same, and as you can see its all already known what it all about, and for now there no needs for another tests, but fixing of websockets code need it. And of course its the same on 1.16, its wellknown, and by me, and by you, and bugs.os4depot.net know it too.

In other words, instead of repeating of now-non-necessary-tests-as-they-done-and-results-in-previous-posts, just fix that problem with non working websockets and send me diffs :) I.e. not fixing of just crash (as i already do), but making them works as they should on os4 :)

I can just disable websockets at all, and no crashes will be , but then it will luck some functionality in compare with morphos which is suck.

@All
Is there no one who can fix it ? I uploaded files there:
http://kas1e.mikendezign.com/temp/shit_crashes/files/

@kas1e

Quote:

That was the idea ..

Quote:

Haha sure just wait some more years until i learn somethings about

@all
As no one want to step in, i just enable debug everywhere in the BCSocketStreamHandleCurl and whole websockets, and do 2 test by going to websocket.org/echo.html and press "connect" button.

1 test: with my fix disabled (i.e. original Fab's code):

Quote:


2 test: with my fix enabled:

Quote:

And no crash, but "disconnected" in the log of websocket connection.

What it mean, is that in both cases websockets for us just didn't works and didn't connects. And for us it crashes and fix need it because some general functionality not works, while for morphos it works , and so they have no crash and have no needs to protect it

Damn, really hate to dig in all of this ! I somehow feel it will be about some opening of ISocket interface somewhere or kind.. Maybe all those recv()/send() in BCSocketStreamHandleCurl should be from ISocket with all necessary initialisation (but tried, and same).

@kas1e

Have you posted this problem over on the Hyperion forums, or on OS4coding? I think you may get better results there.


Scott

@kas1e

And what does MOS Odyssey debug_output/show with:

1 test: with my fix disabled (i.e. original Fab's code)


Maybe we can "see" if there is some difference between OS4 & MOS Odyssey (apart of crashing/not_crashing/working/not_working).

@Scott
that make no big sense as all ppls from os4coding are here, and those at hp forum are here too. and basically, only real help in that case can come only from Fab , and maybe from Joerg , and they both here and only them know that code.

@javier
that what i think about too, but "mos debug" mean compile mos version of odyssey (as enable debug mean adding of bunch of kprintfs as i do now for os4), and that mean build all the 3d party libs for mos and deal with all that mos related moments. probably if nothing will come in next days will build mos version to compare outputs so can see at least whatshould be and where.

As i see it from debug log, we have just didFailSocketStream() from websockets/WebSocketChannel.cpp , when we do platformSend() from BCSocketStreamHandleCurl.cpp, and code in question imho is that platformSend():

Quote:

That why i think that just send() fail (and trying ISocket->send() with opening of bsdsocket.library/interface in the socketstreamhandle , etc without luck).

@kas1e

You can try to change the timeouts on the socket.

setscokopt( sockfd, SOL_SOCKET, SO_RCVTIMEO, &TimeVal, SizeOf(TimeVal) );

and

setscokopt( sockfd, SOL_SOCKET, SO_SNDTIMEO, &TimeVal, SizeOf(TimeVal) );

Also check errno, In case you don't, maybe get a useful error.

@all

I didn't want to create a new thread, so here's my question.

Am i able to change the search engine used when i type something in the URL field?
It always uses google, which i don't want.
I searched hi and lo in the Settings but the only Search engine i could change is the one right next to the URL field. (Windows/Search Engines)

Is there a way in 1.16 respectively will there be a way in 1.23 to change this search engine aswell?

Thanks a lot for the ongoing support

@kas1e

Quote:It has full support. Of course features added to WebKit after OWB development was stopped by Sand-Labs/Pleyo can't work.

Quote:It's very obvious what you are doing wrong, but as long as you don't remove the malware parts (bug #640) from your Odyssey builds, and instead of fixing it even tell users to mess around with the OWB executables breaking features in it, you wont get any help from me any more.

@Raziel

In URL string you can invoke another search engine by using its shortcut (configurable in search engine settings). So for instance, "y blah" to search on youtube or "a blah" to search on aminet.

@joerg
Quote:

It crashes on security websocket's tests with DSI/nullpointer (while should't) as well as html5test.com says your version have "partial" support (but that can be of course because of webkit in your owb which are years old, but crashes on security checks are bad for sure): while for odyssey, html5test says it have full websockets support, and didn't crashes on secutrity websockets (but security ones also didn't works anyway, just pure disconnect, but that still better than crash, of course).

@Fab
Do you have any problems if i will just rename "owb" binary to "odyssey" so joerg be happy and can help with websockets fix ? I mean, will it stop factor for you to continue share sources if i will do so, or you have no problems with ? I just do not want to loose my time (and have no big interest in general) to fix myself that websockets crap, while joerg know the solution and just do not want to say how to fix it because of that boring moment about arexx port (which for me, does not matter at all, i even can call it omiga1200.exe).

At least for me, i see no reassons why Joerg worry at all about name clashes, if he didn't update his owb for years and never will. Just sounds a bit strange imho to worry about no-more-in-developer-version. But , if pure rename will bring us websocket's fix , them i have no problems myself to rename it, if you (fab), have no problems with it too, and that will be no stop factor to share sources of next versions.

Of course i can keep it as it, and fix it myself, but that will take more time, besides if joerg already know how to fix it and his version prove that he make it works.

Btw, i even yesterday tried to start build mos version (to enable debug in websockets and to see differences, and so can get what wrong and how it should looks like), and (of course it was expected) start to meet with problems with morphos cross-compiler, which i didn't have with aos4 cross compiler : i.e. cmake by some reassons fail to found ppc-morphos-g++, while, i can run it from shell and make binaries fine, and i even see that cmake-test also compile binary fine, but still says that can't find compiler. I will happy skip all that boring crap if pure renameing of "owb" to "odyssey" will give us necessary code changes to have working websockets.

EDIT: Only today found that on cygwin, i need for morphos use exactly ppc-morphos-gcc-4.4.5.exe and ppc-morphos-g++-4.4.5.exe (with .exe at end) in morphos.cmake, as for example pure ppc-morphos-g++/ppc-morphos-gcc or pure ppc-morphos-g++-4.4.5/ppc-morphos-gcc-4.4.5 make cmake fail. At least now it start compiles.

And to add to all bunch of problems, i found lately, that 1.23 from time to time crashes on Javascript in blockfree, when i exit from odyssey. Not offten, but from time to time. With 0xCCCCCCC too.

@Fab

Aaah, thats what the shortcut is for

Thanks a lot, Fab, and thank you aswell for the ongoing support and development

Quote:

I can't see any reason why you even need to ask fab about this? Ofcourse for politeness sake maybe, but you are making an AmigaOS 4 port of the program ans the reasons to change it are exactly the same as the reasons to keep it the same on morphos. ie that OS 4 is configured to use OWB for Joergs program by default. The supplied scripst can be easily fixed, changing a port name in a script is trivial.

@broadblues

Yes, he is asking out of courtesy. What you should be more focused on analyzing is why Joerg is acting that way when he was very well paid for a pretty crappy browser.

@magnetic,

That is a little unfair.
Software evolves, with later versions often making the first releases pale by comparison.
I remember using Joergs browser and finding it a delight compared to those that it replaced.
If we want Joergs contributions to resume, then referring to his work in such a derogatory way is a sure way to block that.

@magnetic
It was good enough when Joerg works on it, and for example font handling done much better than in odyssey still (without usage of that fontconfig), and i even reuse in last ports of odyssey his work: native mouse pointers (in 1.9 already) and support of locales and threaded curl (in 1.16 and now in 1.23 too). Sure i also wish that he didn't act like that just because of that arexx thing, but from another side he spend lots of time on, and want to protect it all somehow to avoid side effects. I even hope he someday will add new webkit code to it, and add (at last) download manager , and will not say owb is not browsers, as users do not care about how it call and what is it, they just want modern webkit core + gui at top of it. But, i assume it will not happens as he have no time/motivation for, imho.


@all
Start some debugging by printing stuff in platformsend():



And when we do connect on websocket.org that what we have:

Quote:

So "::send" fail to send, and errno says "bad file number", which can mean invalid descriptor or so i assume (as there is no file at all, we just send data to).

@magnetic

That "crappy browser" is still my main web browser (combined with OWBUtilities tool set), that does more or less everything I need. It's fast, rather light weighted and still has the best font rendering from all available alternatives.

@kas1e,
many years are passed from my c++ programming days,
but in your file BCSocketStreamHandleBaseWK.cpp I cannot
see a send method with the parameters you are using in the call, the only send I see it's:
bool SocketStreamHandleBase::send(const char* data, int length)
which lack the first parameter, the socket, maybe it's
a define, but not having all the includes it's difficult to say and a code like this I think that cannot be compiled

@pvanni
There is few more "send" in websocket files, but all of them have different set of params. And as i know nothing about c++ , i leave it for those skilled ppls who know it.

@magnetic
You don't have ANY idea how much work Joerg put into (what was at the time) the most modern & standards-compliant Amiga web browser available. He was the first person to make a usable port of the WebKit engine on any Amiga-like platform, which was no small feat considering the size & complexity of the source code.

It is a real shame that he only ever saw OWB as a "stop gap" solution, until someone ported a 'real' (fully featured) web browser to AmigaOS4, but that's his perogative.

Any monies sent to him were gifts to thank him for all the work he had done. I myself sent him a fairly sizable donation shortly before he announced stopping work on OWB.