Odyssey 1.23 progress: r5 RC2

	Bottom Previous Topic Next Topic
Register To Post

« 1 ... 28 29 30 (31) 32 33 34 ... 72 »

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 16:17 #611

Just can't stay away

@samo79

Yes, maybe the same bug. I reported here :

http://www.amigans.net/modules/xforum ... um=3&topic_id=6982&order=

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 18:31 #612

Home away from home

@all
A little more tweaks by deadwood's patches (old one was incomplete): https://www.sendspace.com/file/p6de1n

Join us to improve dopus5!
AmigaOS4 on youtube

nubechecorre

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 20:44 #613

Just can't stay away

@Kas1e

ok I downloaded this new test version and it worked for about two minutes before crashing here on amigans.net

please tell me if you need the crashlog and where can i upload it or if you want it by email

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 21:09 #614

Home away from home

@numberchecorre
You tried first one, or second one ? Second one is "full" as should be with deadwood's patches. If it crashes and worse than before, then probably we can't apply them just like this, sadly.

Join us to improve dopus5!
AmigaOS4 on youtube

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 21:26 #615

Just can't stay away

@kas1e
Using second one since few times, no crash.

TearsOfMe

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 21:49 #616

Just popping in

@kas1e
Using second one since few times, no crash.
Here also.

Kicko

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 22:12 #617

Just can't stay away

Using second one for about 2 hours. Only one crash while watching a videoclip but thats the old mediaplayer bug. Other then that working nice. Cool with the continue work on odyssey :)

samo79

Re: Odyssey 1.23 progress

Posted on: 2016/1/8 22:28 #618

Home away from home

@kas1e

Tested both versions (3 hours of intensive usage) and no crash at all :)
More or less it same stable as the standard version on OS4Depot

jabirulo

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 0:07 #619

Just can't stay away

@kas1e

2 little quirks:

Can the $VER: date at least be changed so we can "know" what version/release are we running?

Catalog (owb.catalog) doesn't seems to be closed on quit/exit, as I can't flush it from memory to test updated/fixed localization. Thus i need to fast reboor miggy to test updated catalog

EDIT: And what internal date/time UTC uses, just posted this at 1H00 Madrid, Spain time and it shows 3H00 ¿:-/

TIA

jabirulo

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 0:07 #620

Just can't stay away

Ooops. double post.

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 0:15 #621

Just can't stay away

@jabirulo
"Catalog (owb.catalog) doesn't seems to be closed on quit/exit, as I can't flush it from memory to test updated/fixed localization"

Even with "expunge locale.library" (or by double-clicking on libraries/Catalogs list of SysMon) ?

tommysammy

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 5:32 #622

Quite a regular

Odyssey1.23 fix2 seems to be better working than original Odyssey 1.23
I have to do more testing
@kas1e can you fix the Ahi bug?
When i am running AmigaAmp and start then a Youtube video, i get no sound of the Youtube video
Start i first a Youtube video then i can not start AmigaAmp
Both programs are using the same Ahi channel. Odyssey need an option to switch the Ahi channel when it is occupied

Amiga600/Vampire2/PrismaMegaMix/32GB CF Card/2x Rys Mk2/A604n/IndivisionECS/Gotek

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 10:31 #623

Home away from home

@Jabirulo
Quote:

Catalog (owb.catalog) doesn't seems to be closed on quit/exit, as I can't flush it from memory to test updated/fixed localization. Thus i need to fast reboor miggy to test updated catalog

That strange, because:

locale.cpp:


#include "gui.h"



/* public */

#include <proto/dos.h>

#include <proto/exec.h>

#include <proto/locale.h>

#include <libraries/locale.h>



/* private */

#include "alocale.h"

#include "owb_cat.h"



static struct Catalog *catalog;



struct Locale *locale;



LONG   locale_timezone_offset;



ULONG locale_init(void)

{    

    locale = OpenLocale(NULL);



    locale_timezone_offset = -locale->loc_GMTOffset * 60;



    catalog = OpenCatalog(

        NULL, "OWB.catalog",

        OC_BuiltInLanguage, "english",

        OC_Version, 1,  /* required catalog version */

        TAG_DONE

    );



    if (catalog)

    {

        int c;



        for (c = 0; c < NUMCATSTRING; c++)

        {    

            #ifdef __amigaos4__

            ((char**)__stringtable)[ c ] = (char *)GetCatalogStr(catalog, c, (char*)__stringtable[c]);

            #else

            ((char**)__stringtable)[ c ] = GetCatalogStr(catalog, c, (char*)__stringtable[c]);

            #endif

        }

    }

    return (TRUE);

}



void locale_cleanup(void)

{

    CloseLocale(locale);

    CloseCatalog(catalog);

}

And then, in the main:


if(open_libs())

    {

        if(safety_check())

        {

            app = create_application(argc > 1 ? (char*)argv[1] : (char *)"");



            if(app)

            {

                main_loop();

            }



            destroy_application();

        }

    }

    close_libs();

Where destroy_application() are:


void destroy_application(void)

{

    if(app)

    {

        MUI_DisposeObject(app);

        methodstack_cleanup();

        classes_cleanup();

        locale_cleanup();

        app = NULL;

    }

}

So probably it should be ok.

Join us to improve dopus5!
AmigaOS4 on youtube

tboeckel

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 10:43 #624

Just popping in

locale_cleanup() should be called independently of the application object.

Why stop it now, just when I am hating it?

Thore Böckelmann

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 11:26 #625

Home away from home

@Thore
Why ?

Join us to improve dopus5!
AmigaOS4 on youtube

Breed

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 12:33 #626

Just popping in

Big thank you, fixed version seems to work much smoother on my X1000.
Now I can listen AmigaRemix songs via OWB and netradio stations wich I have listened using OWB seems to working better (earlier versions ate memory after about one hour listening and then my Amy crached)
ps: small motivation donation sent, I recomment to all

\o/....X1000....\o/

tboeckel

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 12:49 #627

Just popping in

@ kas1e

Because the catalog will be closed only if creating the application succeeded before. Otherwise you have a memory leak. Unprobable, but not impossible. I don't know how safety_check() and create_application() look like, but I suppose the catalog will be opened before the application is created.

Why stop it now, just when I am hating it?

Thore Böckelmann

MickJT

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 13:25 #628

Just can't stay away

@kas1e

http://www.amigans.net/modules/xforum/viewtopic.php?post_id=99737

Building it against the latest OpenSSL should fix that.

trixie

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 14:34 #629

Amigans Defender

@kas1e

Thank you for the upload! A brief report from me:

- Odyssey registers as a commodity. I guess this is unnecessary? Why would a 60MB mammoth browser application want to be a commodity? Commodities are primarily service programs.

- The commodity support is broken anyway. Upon receiving CXCMD_DISAPPEAR Odyssey iconifies instead of hiding; this is contrary to the usual conventions. If the program receives a CXCMD_KILL when it is iconified, Odyssey neither quits, nor can it be uniconified again: the icon just stays "locked" on the WB. (I suspect the CXCMD_KILL-handling code does not account for the window being not open at the moment the message arrives.)

- Odyssey registers as an application but there is virtually no application.library support. The program does not respond to APPLIBMT_Hide or APPLIBMT_Unhide messages, although iconification is apparently supported. APPLIBMT_Quit is not implemented either.

I can fix this for you if this part is in plain C.

The Rear Window blog

AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition

LiveForIt

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 14:49 #630

Home away from home

@kas1e


void locale_cleanup(void) 

{ 

    CloseLocale(locale); 

    CloseCatalog(catalog); 

}

This code, you can make safer by doing:


void locale_cleanup(void) 

{ 

   if (locale) CloseLocale(locale); 

   if (catalog) CloseCatalog(catalog); 



   locale = NULL; catalog = NULL;

}

This prevent nasty crashes, If local_cleanup() is called more than once, by accident, or things like that. That’s how I always do my clean up code. And this make easier to find issues where locale might be used after its freed and so on.

Register To Post	« 1 ... 28 29 30 (31) 32 33 34 ... 72 »
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )