Strange crash with Enhancer DIR (54.5)

	Bottom Previous Topic Next Topic
Register To Post

FlynnTheAvatar

Posted on: 2023/5/29 12:09 #1

Just popping in

Hi,

I was trying to run the tests from the adtools_testing repo on my X5020. But the Enhancer DIR command (Version 54.5) constantly crashed with an DSI.

Crash log:


kernel 54.30 (1.1.2021) AmigaOne X5000 release

Machine model: 9 (AmigaOne X5000/20)

Dump of context at 0xEFD80BA0

Trap type: DSI exception

DSISR: 00800000  DAR: 662BA000

Page: 0xEFD52EA0 (Virtual: 0x662BA000, Physical: 0x00000000, Flags: 0x 800)

Machine State (raw): 0x0002D030

Machine State (verbose): [Critical Ints on] [ExtInt on] [User] [IAT on] [DAT on]

Instruction pointer: 0x7F8F2344

Crashed process: DIR (0x680BFB10)

DSI verbose error description: Access to address 0x662BA000 not allowed by page protection in user state (protection violation)

Access was a store operation

Exception Syndrome Register: 0x00800000

 0: 019152AC 662B0E90 00000002 FFFFFFFF 68AC9B48 46494C45 46490000 00000006

 8: 7F8F2344 00000000 0191529C 01837D5C 7F8F2308 6AE86000 FFFFFFFF 662159AC

16: 6698DB80 EFE15F10 00010000 01930000 662159A8 680BFB5A 00000000 66257110

24: 00000000 6AC720B0 0227ECC2 1A2B26D2 00000000 6AC720A0 662BA000 01915248

CR: 39953953   XER: A000007E  CTR: 01837D5C  LR: 7F8F2344



Disassembly of crash site:

 7F8F2334: 7F64DB78   mr                r4,r27

 7F8F2338: 83FF0000   lwz               r31,0(r31)

 7F8F233C: 7FE803A6   mtlr              r31

 7F8F2340: 4E800021   blrl

>7F8F2344: 987E0000   stb               r3,0(r30)

 7F8F2348: 895E0000   lbz               r10,0(r30)

 7F8F234C: 7D4A0774   extsb             r10,r10

 7F8F2350: 3BDE0001   addi              r30,r30,1

 7F8F2354: 2C0A0072   cmpwi             r10,114

 7F8F2358: 4082FFD4   bne+              0x7F8F232C

msr: 0x0002B032

TLB1 (64 entries):

 * [ 50]: size=7 tid = 0 TS = 1 epn=0xFE000000 rpn=0x0000000F_FE000000 WIMG=0x5 XXWWRR=0xF protected

 * [ 51]: size=6 tid = 0 TS = 1 epn=0x01000000 rpn=0x00000000_01000000 WIMG=0x0 XXWWRR=0x5 protected

 * [ 52]: size=6 tid = 0 TS = 1 epn=0x01400000 rpn=0x00000000_01400000 WIMG=0x0 XXWWRR=0x5 protected

 * [ 53]: size=6 tid = 0 TS = 1 epn=0x01800000 rpn=0x00000000_01800000 WIMG=0x0 XXWWRR=0x33 protected

 * [ 54]: size=6 tid = 0 TS = 1 epn=0x01C00000 rpn=0x00000000_01C00000 WIMG=0x0 XXWWRR=0x33 protected

 * [ 55]: size=5 tid = 0 TS = 1 epn=0x02000000 rpn=0x00000000_02000000 WIMG=0x0 XXWWRR=0xF protected

 * [ 56]: size=5 tid = 0 TS = 1 epn=0x02100000 rpn=0x00000000_02100000 WIMG=0x0 XXWWRR=0xF protected

 * [ 57]: size=5 tid = 0 TS = 1 epn=0x02200000 rpn=0x00000000_02200000 WIMG=0x0 XXWWRR=0xF protected

 * [ 58]: size=3 tid = 0 TS = 1 epn=0x02300000 rpn=0x00000000_02300000 WIMG=0x0 XXWWRR=0xF protected

 * [ 59]: size=3 tid = 0 TS = 1 epn=0x02310000 rpn=0x00000000_02310000 WIMG=0x0 XXWWRR=0xF protected

 * [ 60]: size=3 tid = 0 TS = 1 epn=0x02320000 rpn=0x00000000_02320000 WIMG=0x0 XXWWRR=0xF protected

 * [ 61]: size=7 tid = 0 TS = 0 epn=0xFE000000 rpn=0x0000000F_FE000000 WIMG=0x5 XXWWRR=0xF protected

 * [ 62]: size=A tid = 0 TS = 0 epn=0x00000000 rpn=0x00000000_00000000 WIMG=0x0 XXWWRR=0x3F protected

 * [ 63]: size=A tid = 0 TS = 0 epn=0x40000000 rpn=0x00000000_40000000 WIMG=0x0 XXWWRR=0x3F protected

HAL_MaxTLB = 49, HAL_NextTLB = 0

MMUCFG = 0x064809C4

mas0 = 0x103F0000

mas1 = 0xC0000A00

mas2 = 0x40000000

mas3 = 0x4000003F

mas4 = 0x00000100

mas5 = 0x00000000

mas6 = 0x00000001

mas7 = 0x00000000

mas8 = 0x00000000



Kernel command line: serial debuglevel=5 munge



Registers pointing to code:

r0 : native kernel module dos.library.kmod+0x0001242c

r8 : module DIR at 0x7F8F2344 (section 0 @ 0x320)

r10: native kernel module dos.library.kmod+0x0001241c

r11: native kernel module kernel+0x00037d5c

r12: module DIR at 0x7F8F2308 (section 0 @ 0x2E4)

r19: native kernel module dos.library.kmod+0x0002d180

r26: native kernel module kernel+0x00a7ecc2

r31: native kernel module dos.library.kmod+0x000123c8

ip : module DIR at 0x7F8F2344 (section 0 @ 0x320)

lr : module DIR at 0x7F8F2344 (section 0 @ 0x320)

ctr: native kernel module kernel+0x00037d5c



Stack trace:

(0x662B0E90) module DIR at 0x7F8F2344 (section 0 @ 0x320)

(0x662B0EF0) module DIR at 0x7F8F2344 (section 0 @ 0x320)



Disassembly of crash site:

 7F8F2334: 7F64DB78   mr                r4,r27

 7F8F2338: 83FF0000   lwz               r31,0(r31)

 7F8F233C: 7FE803A6   mtlr              r31

 7F8F2340: 4E800021   blrl

>7F8F2344: 987E0000   stb               r3,0(r30)

 7F8F2348: 895E0000   lbz               r10,0(r30)

 7F8F234C: 7D4A0774   extsb             r10,r10

 7F8F2350: 3BDE0001   addi              r30,r30,1

 7F8F2354: 2C0A0072   cmpwi             r10,114

 7F8F2358: 4082FFD4   bne+              0x7F8F232C

Stack pointer (0x662B0E90) is inside bounds

Redzone is OK (4)



68k register dump

DATA: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000

ADDR: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000

Page information:

Page 0xEFD52EA0:

Virtual Address: 0x662BA000

Physical Address: 0x00000000

Lock count: 0

Flags (0x800): (Guard)

Protection bits (0x0): (super state only)

Page is assigned to VMArea primary heap



Ready Tasks

               HOME_SMB2FS/smb2-handler 53.4  (pri   5, sigrec 0x80000180, sigwait 0xC0000000, masked 0x80000000)

              MUSIC_SMB2FS/smb2-handler 53.4  (pri   5, sigrec 0x80000180, sigwait 0xC0000000, masked 0x80000000)

              AMIGA_SMB2FS/smb2-handler 53.4  (pri   5, sigrec 0x80000180, sigwait 0xC0000000, masked 0x80000000)

                           WinFrame 1 Process (pri   5, sigrec 0x00800000, sigwait 0xFF800000, masked 0x00800000)

                    IDF0/FastFileSystem 53.2  (pri   5, sigrec 0x20000000, sigwait 0xA8000100, masked 0x20000000)

                    IDF1/FastFileSystem 53.2  (pri   5, sigrec 0x20000000, sigwait 0xA8000100, masked 0x20000000)

                                 compose.task (pri   1, sigrec 0x00000010, sigwait 0x00000010, masked 0x00000010)

                                    Workbench (pri   1, sigrec 0xC0000180, sigwait 0x80000000, masked 0x80000000)

                Bildschirmschoner-Bibliothek. (pri   1, sigrec 0x04000100, sigwait 0xB4001000, masked 0x04000000)

                           NotificationServer (pri   0, sigrec 0x04000000, sigwait 0xBC001000, masked 0x04000000)

                                      AmiDock (pri   0, sigrec 0x00080100, sigwait 0x00000100, masked 0x00000100)

                                     Calendar (pri   0, sigrec 0x04000000, sigwait 0xDC001000, masked 0x04000000)

                               TCP/IP Control (pri   0, sigrec 0x50000100, sigwait 0xF8009080, masked 0x50000000)

                                ELF Collector (pri   0, sigrec 0x00000100, sigwait 0x00000100, masked 0x00000100)

                                    hub.usbfd (pri   0, sigrec 0x10000000, sigwait 0x30000000, masked 0x10000000)

                                    hub.usbfd (pri   0, sigrec 0x10000000, sigwait 0x30000000, masked 0x10000000)

                                        Clock (pri   0, sigrec 0x02000000, sigwait 0x6E001000, masked 0x02000000)

                               Background CLI (pri   0, sigrec 0x10000100, sigwait 0xD0001080, masked 0x10000000)

                            dos_signal_server (pri  -5, sigrec 0x00004100, sigwait 0x00000100, masked 0x00000100)

                             CPUDock_idleTask (pri -127, sigrec 0x00000000, sigwait 0x40000000, masked 0x00000000)

                                    idle.task (pri -128, sigrec 0x00000000, sigwait 0x00000000, masked 0x00000000)



Waiting Tasks

                      DH1/NGFileSystem 54.34  (pri  10, sigrec 0x00000100, sigwait 0xF0000000, masked 0x00000000)

                      DH2/NGFileSystem 54.34  (pri  10, sigrec 0x00000100, sigwait 0xF0000000, masked 0x00000000)

                      DH0/NGFileSystem 54.34  (pri  10, sigrec 0x00000100, sigwait 0xF0000000, masked 0x00000000)

                                 input.device (pri  20, sigrec 0x00000000, sigwait 0x80000000, masked 0x00000000)

                               P50x0 Ethernet (pri  20, sigrec 0x00000000, sigwait 0x00001000, masked 0x00000000)

            sii3114ide.device - chip 0 port 0 (pri  12, sigrec 0x00008000, sigwait 0xC0000000, masked 0x00000000)

                  EHCI Controller Task Unit 1 (pri  15, sigrec 0x00000000, sigwait 0xBE009000, masked 0x00000000)

                  EHCI Controller Task Unit 0 (pri  15, sigrec 0x00000000, sigwait 0xBE009000, masked 0x00000000)

                                    USB stack (pri  18, sigrec 0x00000000, sigwait 0xF800D000, masked 0x00000000)

                               Background CLI (pri   0, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                           dos_filedir_notify (pri   5, sigrec 0x80000000, sigwait 0x40001000, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000080, sigwait 0xB0000100, masked 0x00000000)

                                        rx_gc (pri 100, sigrec 0x00000000, sigwait 0x80000001, masked 0x00000000)

                      p50x0sata.device Port 1 (pri  12, sigrec 0x10000000, sigwait 0xC0007000, masked 0x00000000)

                                    hid.usbfd (pri  10, sigrec 0x00000100, sigwait 0xE0000000, masked 0x00000000)

                                 HID Keyboard (pri  10, sigrec 0x00000000, sigwait 0x90001000, masked 0x00000000)

                                    TimeGuard (pri   0, sigrec 0x04000100, sigwait 0xF0001000, masked 0x00000000)

                               Background CLI (pri   0, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                                Shell Process (pri   0, sigrec 0x00000080, sigwait 0x00000100, masked 0x00000000)

                      p50x0sata.device Port 0 (pri  12, sigrec 0x10000000, sigwait 0xC0007000, masked 0x00000000)

                        appdir envarc manager (pri -50, sigrec 0x80000000, sigwait 0x00000100, masked 0x00000000)

                                serial.device (pri   1, sigrec 0x00000000, sigwait 0x7E000000, masked 0x00000000)

                           vsata disk changer (pri   0, sigrec 0x00000000, sigwait 0x80000000, masked 0x00000000)

                      ICD1/CDFileSystem 53.8  (pri  10, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                      ICD0/CDFileSystem 53.8  (pri  10, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                       CD0/CDFileSystem 53.8  (pri  10, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                                   « IPrefs » (pri   0, sigrec 0x00000000, sigwait 0x0000F000, masked 0x00000000)

                                    hid.usbfd (pri  10, sigrec 0x00000100, sigwait 0xE0000000, masked 0x00000000)

                                    HID Mouse (pri  10, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                           TCP/IP Superserver (pri   0, sigrec 0x00000100, sigwait 0xD0000080, masked 0x00000000)

                                 ClickToFront (pri  21, sigrec 0x00000100, sigwait 0xE000D000, masked 0x00000000)

                                 ContextMenus (pri   0, sigrec 0x00000100, sigwait 0xE0001000, masked 0x00000000)

                    URL/launch-handler 53.39  (pri   5, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

              TEXTCLIP/textclip-handler 53.4  (pri   3, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                  RANDOM/Random-Handler 52.1  (pri   5, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                               ramlib.support (pri  -2, sigrec 0x00000000, sigwait 0x80005000, masked 0x00000000)

                                       ramlib (pri   1, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                                 Mounter Task (pri  -1, sigrec 0x00000000, sigwait 0xB0001000, masked 0x00000000)

                                  Mounter GUI (pri   0, sigrec 0x00000000, sigwait 0x80007000, masked 0x00000000)

                    Mounter Companion Process (pri  -1, sigrec 0x00000000, sigwait 0x80003000, masked 0x00000000)

                     Workbench DosList Notify (pri   1, sigrec 0x00000100, sigwait 0x00003000, masked 0x00000000)

                                 HID Consumer (pri  10, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                                    hub.usbfd (pri   0, sigrec 0x00000000, sigwait 0x30000000, masked 0x00000000)

                          ScreenBlankerEngine (pri   0, sigrec 0x00000100, sigwait 0xD8001000, masked 0x00000000)

                                    hid.usbfd (pri  10, sigrec 0x00000100, sigwait 0xE0000000, masked 0x00000000)

                         TCP/IP Configuration (pri   0, sigrec 0x00000100, sigwait 0xF8003000, masked 0x00000000)

                      clipview.library server (pri   0, sigrec 0x00000000, sigwait 0xD8003000, masked 0x00000000)

                                   RexxMaster (pri   4, sigrec 0x00000100, sigwait 0xC0000000, masked 0x00000000)

              ContextMenus Command Dispatcher (pri   1, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

            application.library messageserver (pri   0, sigrec 0x00000000, sigwait 0xC0000000, masked 0x00000000)

                                      AsyncWB (pri   0, sigrec 0x00000100, sigwait 0xC0001000, masked 0x00000000)

                                       InfoWB (pri   0, sigrec 0x00000100, sigwait 0xF8001000, masked 0x00000000)

           texteditor.gadget Clipboard Server (pri   1, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                          select.gadget prefs (pri   0, sigrec 0x00000100, sigwait 0x80001000, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                                     DefIcons (pri   0, sigrec 0x00000100, sigwait 0x80009000, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                         string.gadget server (pri   1, sigrec 0x00000100, sigwait 0x40000000, masked 0x00000000)

                   Workbench Clipboard Server (pri   1, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                                   TCP/IP Log (pri   0, sigrec 0x00000000, sigwait 0x80003000, masked 0x00000000)

                                      ConClip (pri   0, sigrec 0x00000000, sigwait 0x80000000, masked 0x00000000)

                                 HID Consumer (pri  10, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                      diskimage.device unit 1 (pri   4, sigrec 0x00000100, sigwait 0xC0000000, masked 0x00000000)

                                 HID Consumer (pri  10, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                                    hid.usbfd (pri  10, sigrec 0x00000100, sigwait 0xE0000000, masked 0x00000000)

                      diskimage.device unit 0 (pri   4, sigrec 0x00000100, sigwait 0xC0000000, masked 0x00000000)

                      diskimage.device unit 5 (pri   4, sigrec 0x00000100, sigwait 0xC0000000, masked 0x00000000)

                      diskimage.device unit 4 (pri   4, sigrec 0x00000100, sigwait 0xC0000000, masked 0x00000000)

                            USB stack Process (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       AUDIO/AHI-Handler 6.2  (pri   5, sigrec 0x00000000, sigwait 0x00000100, masked 0x00000000)

                 APPDIR/appdir-handler 54.17  (pri   5, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                         MassStorage Notifier (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                                  DST watcher (pri   0, sigrec 0x00000000, sigwait 0xC0000000, masked 0x00000000)

                       RAM/ram-handler 54.24  (pri  10, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                       ENV/env-handler 54.18  (pri   5, sigrec 0x00000100, sigwait 0x80000000, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       RAW/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                       CON/con-handler 53.82  (pri   5, sigrec 0x00000000, sigwait 0xA0000100, masked 0x00000000)

                             dos_nbmd_process (pri   5, sigrec 0x00000000, sigwait 0x00001100, masked 0x00000000)

                             dos_lock_handler (pri   5, sigrec 0x00000000, sigwait 0x00001100, masked 0x00000000)

                                    hub.usbfd (pri   0, sigrec 0x00000000, sigwait 0x30000000, masked 0x00000000)

                                    hub.usbfd (pri   0, sigrec 0x00000000, sigwait 0x30000000, masked 0x00000000)

                                    hub.usbfd (pri   0, sigrec 0x00000000, sigwait 0x30000000, masked 0x00000000)

                     Exec Command and Control (pri  30, sigrec 0x00000000, sigwait 0x80000000, masked 0x00000000)

                       DMA2 Channel 4 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA1 Channel 4 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA2 Channel 3 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA1 Channel 3 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA2 Channel 2 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA1 Channel 2 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA2 Channel 1 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)

                       DMA1 Channel 1 Handler (pri   0, sigrec 0x00000000, sigwait 0x80001000, masked 0x00000000)



Suspended Tasks

The crashing command is


execute `dir #?.script`

Running the command without the backticks work. With backticks it crashes.

Update:
Minimal test case:


cd RAM:

makedir test

cd test

touch test.script

echo `dir #?.script`

Edited by FlynnTheAvatar on 2023/5/29 12:34:36

rjd324

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 12:36 #2

Quite a regular

Hi. I can reproduce that on my 5020 also.


$version dir

Dir 54.5

The reason I used that command was because I was in linux-mode, where expansion happens before the command is executed. This is not the way it works in Amiga land since:


dir my#?

will not perform an expansion before invoking the dir command.

Since that was the case, I decided to use:


execute `dir my#?`

with the intention to pull back the relevant script name and then execute it.

But, as you say there is an issue with this for whatever reason. I am not sure if Amiga does perform the expansion in the backticks first - in fact, it MUST. So, why DIR is failing I am not sure.

===

As you know, by default the command script in adtools_testing comments that out - if there is a better approach then please do a PR.

But, the question remains: why is this causing a crash?

FlynnTheAvatar

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 12:38 #3

Just popping in

@rjd324

This is a bug in DIR 54.5.

I switched to the DIR coming with the installation CD (Version 53.3), and it works without any issue.

rjd324

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 12:40 #4

Quite a regular

Surprise, surprise - I wonder if the command was actually tested on OS4 and not just tested on System v54. Although, using the output of a subshell as an argument to DIR is probably not done that often; I guess such a test case can be forgiven for being missed; personally, I would have tested it. And... that is if there is any testing at all.

amigakit

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 15:19 #5

Quite a regular

@ FlynnTheAvatar

Thanks for the bug report. Our developer is fixing it now. We will have a fixed version on Updater soon.

@rjd324

Quote:

that is if there is any testing at all

Of course it was tested by the Enhancer Software beta test team with OS4. We do not publish software blindly. When a bug slips through the net and is identified it is fixed as soon as possible. Then we quickly make the fixed command available to users.

amigakit.com - the Amiga store
Links: www.amigakit.com | New Products | Enhancer Software

MamePPCA1

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 17:55 #6

Quite a regular

@amigakit

I only want to contact you (I tried about 5 or 6 times some weeks ago or more) to remind you that you still have my Amiga 1200 and I want to pay for it.

Can you send me now? Is very important to me.

Thanks

Javier Vega

Amiga 500 1MB Chip RAM with ACA 500+ACA1232,CD32,Amiga 1300 030/50 Mhz,32MB (now on my hands at least)and Amiga One G3 XE PPC 800 Mhz,ATI Radeon 9250 128 MB,256 MB RAM,Seagate 200 GB HD,2 working DVD drives,X-Arcade double for MAME,Sil0680,4 USB ports,LG

cnicol

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 20:21 #7

Just popping in

Hi,

The bug is now fixed in Dir 54.7

It was caused by failing to get the column width of the current console window when Dir output was used as input using backticks.

Some more checks have now fixed the crash and the updated command should be available soon.

Thanks for the report.

Costas.

amigakit

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/29 20:33 #8

Quite a regular

@cnicol

Great work Costas, thank you

We will get Dir 54.7 beta tested again and released soon on Updater

amigakit.com - the Amiga store
Links: www.amigakit.com | New Products | Enhancer Software

FlynnTheAvatar

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/30 5:25 #9

Just popping in

@cnicol

Thank you very much for fixing the bug and the explanation. Yes, I can imagine that this causes serious issues if you need the column length for formatting the output, but you do not get it because of the backticks.

I hope the fixed command is available soon.

MamePPCA1

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/5/30 13:36 #10

Quite a regular

@amigakit

Hello Chris

I think I asked you a question on this forum.

Can you answer me please?

Javi

rjd324

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/6/11 14:34 #11

Quite a regular

Presumably the new version also fixes the situation in the following Makefile:


ifeq ($(BIN),)

$(error Set an environment variable named BIN to point to the command under test)

endif



.PHONY: all

all:

    @echo "Version:"

    @version file full $(BIN)

    @echo "---"

    @echo "Execution:"

    $(BIN)

    @echo "---"

When BIN is set to "Dir". In this case, each line of the recipe is invoked in its own shell environment as per the normal rules of Makefiles.

I see that it works with OS4 Core DIR version 53.3 but crashes with 54.5.

It sounds like it is the same thing...

FYI, tested on an Amiga X[15]000 and:


6.Other:Dev/SVN_AMIGA/dirBug> which make

Programs:SDK/C/make

6.Other:Dev/SVN_AMIGA/dirBug> version make

make 53.1

6.Other:Dev/SVN_AMIGA/dirBug> make --version

GNU Make 3.81

Copyright (C) 2006  Free Software Foundation, Inc.

This is free software; see the source for copying conditions.

There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A

PARTICULAR PURPOSE.



This program built for AmigaOS

Edited by rjd324 on 2023/6/11 17:27:28

cnicol

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/6/11 22:55 #12

Just popping in

Hi,

Yes, Dir 54.7 doesn't seems to have any problem with that makefile.

amigakit

Re: Strange crash with Enhancer DIR (54.5)

Posted on: 2023/6/12 8:45 #13

Quite a regular

@rjd324

Many thanks for your reports - it is appreciated.

Dir V54.7 is now available on Updater to download.

amigakit.com - the Amiga store
Links: www.amigakit.com | New Products | Enhancer Software

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )