|
|
Browsing this Thread:
1 Anonymous Users
|
|
|
Rigo [image]
|
Re: FFmpeg 0.6 |
|
Supreme Council
|
Posts:
870
|
|
Posted on: 2010/7/5 11:20:06
|
|
@MickJT
Quote:
afxgroup wrote:
#ifdef __AMIGAOS4__
strcpy(proto_str, "file");
up = first_protocol;
while (up != NULL) {
if (!strcmp(proto_str, up->name))
return url_open_protocol (puc, up, filename, flags);
up = up->next;
}
#endif
The above strcpy call should be replaced with:
strlcpy(proto_str, "file", sizeof(proto_str) );
Using the strcpy() function assumes the destination storage is large enough to take the 4 characters being copied. In this case it is, but it's far safer to check first. If someone changes the size of the proto_str buffer, there is no check when coping to it that it is large enough, and you'll possibly get a DSI if the buffer overruns.
As I said, in this case it won't be a problem, but you should always use length-checking functions to copy strings around (unless you are only copying the pointer to it, of course).
Simon
|
|
_________________
Comments made in any post are personal opinion, and are in no-way representative of any commercial entity unless specifically stated as such. ---- http://codebench.co.uk
|
 Transfer
|
|
|
|
|
MickJT [image]
|
Re: FFmpeg 0.6 |
|
Just popping in
|
Posts:
198
|
|
Posted on: 2010/7/6 1:19:48
|
|
@ktadd
Bit too slow on here for me to really test it out. Give me 12 hours and i'll encode something overnight. Was/Is there any way to encode to H.264 video on the current ffmpeg_ppc on OS4Depot?
What's your command line?
ffmpeg -i input.mp4 -vcodec libx264 -vpre libx264-default-b 2000k -acodec libfaac -ac 2 output.mp4
Edit: Trying something small now. Will play back on PS3 and PC to check results.
Edit2: You're right, it's horrible. As if the bitrate is too low. I don't know if I can do anything about it, but i'll try. I'm aware that ffmpeg 0.6 and libx264 r100 don't like each either. libx264 complains that ffmpeg has broken default settings, making you use one of the presets (is that what you meant by filters?). I could test a windows build, but i'm guessing they've probably fixed up any issues like these already.
Edited by MickJT on 2010/7/6 2:06:12
|
|
|
| Transfer
|
|
|
|
|
MickJT [image]
|
Re: FFmpeg 0.6 |
|
Just popping in
|
Posts:
198
|
|
Posted on: 2010/7/6 3:13:34
|
|
@ktadd
Well, it's got nothing to do with any changed code. After disabling pthreads, there's no changes at all to the source.
Trying the build of x264 on OS4Depot now (not compatible with ffmpeg 0.6, but I can test some encoding). I didn't encode enough of the file to get a good look the first time round. I'll leave it for a while.
Results: x264 (Fredrik's port), bad quality. x264 (my port) even worse quality. Though there's been several changes between the revisions though. I think mine and Fredrik's ports are both bad. Perhaps the altivec code makes all the difference? His port detects and applies the altivec instructions automatically, while mine has it either on or off. So perhaps he never noticed any problems.
Edited by MickJT on 2010/7/6 3:53:05
|
|
|
| Transfer
|
|
|
|
You can view topic.
You cannot start a new topic.
You cannot reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You cannot post without approval.
Home |
