Login
Username:

Password:

Remember me



Lost Password?

Register now!

Sections

Who's Online
13 user(s) are online (7 user(s) are browsing Forums)

Members: 0
Guests: 13

more...

Support us!

Headlines

 
  Register To Post  

MUI and MUIA_String_EditHook - no IEvent!
Quite a regular
Quite a regular


See User information
Hi,

I just noticed what must be a (recent) bug in MUI on OS4:
I have added a MUIA_String_EditHook and it is supposed to be called with a number of field, like IEvent, but with MUI it is not.
On ReAction it works fine, and I'm 100% sure it must have worked before because I implemented the code 15 years ago for MUI and RA in parallel.

I have a normal StringObject, like this:
Childo[FSSTR]=StringObject,
            
StringFrame,
            
MUIA_ControlChar'f',
            
MUIA_String_MaxLenSTRLEN,
            
MUIA_String_ContentsFindtext,
            
MUIA_String_EditHook, &reqwinhook,
End,

Here is the content of the SGWork in the hook on MUI vs. RA on OS4:
//muios4 reqwinfunc:
StringInfo=0x513f6b94, WorkBuffer=0x4d6d1018, PrevBuffer=0x49897d60,
Modes=16,
IEvent=0,
Code=98, BufferPos=1, NumChars=1, Actions=17, LongInt=0,
GadgetInfo=0, EditOp=8

//ra-os4 reqwinfunc:
StringInfo=0x4d074a34, WorkBuffer=0x54e599b8, PrevBuffer=0x552959b8,
Modes=0,
IEvent=0x6f0e7670,
Code=98, BufferPos=1, NumChars=1, Actions=17, LongInt=0,
GadgetInfo=0x6f295c16, EditOp=8

As you can see, the MUI hook is missing IEvent and GadgetInfo.

The whole point of the hook is to read the up/down arrow keys and navigate a list (string history).
But the hook isn't even called for rawkeys on MUI, so becomes useless even if I could work around the missing IEvent.

This must have worked before, otherwise I wouldn't have implemented it for MUI, but only for RA where it works fine.

muimaster.library 21.227 (2021-08-31)
Copyright (C) 2006-2021 by Thore Boeckelmann, Jens Maus [AmigaOS4/PPC] [git efa6e87] [20210831]

String.mui 21.51 (2021-08-31)
Copyright (C) 2006-2021 by Thore Boeckelmann, Jens Maus [AmigaOS4/PPC] [git efa6e87] [20210831]

Software developer for Amiga OS3 and OS4.
Develops for OnyxSoft and the Amiga using E and C and occasionally C++
Go to top
Re: MUI and MUIA_String_EditHook - no IEvent!
Home away from home
Home away from home


See User information
@Deniil

Reported for you on github:

https://github.com/amiga-mui/muidev/issues/370

Go to top
Re: MUI and MUIA_String_EditHook - no IEvent!
Quite a regular
Quite a regular


See User information
@samo79

Thanks!

I get the impression someone tried to clean/refactor the code but didn't understand how these hooks are supposed to work, and broke it. Not the first time the history of development

Software developer for Amiga OS3 and OS4.
Develops for OnyxSoft and the Amiga using E and C and occasionally C++
Go to top

  Register To Post

 




Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )




Powered by XOOPS 2.0 © 2001-2024 The XOOPS Project