GetFileSize

	Bottom Previous Topic Next Topic
Register To Post

AmiDARK

Posted on: 2009/10/6 23:55 #1

Quite a regular

Hi All,

I Try to use dos lib to open to read/write files.

I have made some functions for this but I encounter some problems.
Here are the functions :


FILE *FileChannel[ 256 ];



void DEFileOpenToRead( int ChannelID, const char *FileName ){

  int FOpened = DEFileOpened( ChannelID );

  if ( FOpened == 0 ){

    if ( ChannelID > 0 ){

      if ( ChannelID < 257 ){

        FileChannel[ ChannelID ] = Open( FileName, MODE_OLDFILE );

       }

     }

   }

 }



void DEFileOpenToWrite( int ChannelID, const char *FileName ){

  int FOpened = DEFileOpened( ChannelID );

  if ( FOpened == 0 ){

    if ( ChannelID > 0 ){

      if ( ChannelID < 257 ){

        FileChannel[ ChannelID ] = Open( FileName, MODE_NEWFILE );

       }

     }

   }

 }



void DECloseFile( int ChannelID ){

  int FOpened = DEFileOpened( ChannelID );

  if ( FOpened == 1 ){

    Close( FileChannel[ ChannelID ] );

    FileChannel[ ChannelID ] = NULL;

   }

 }



void DEMakeMemblockFromFileEx( int MemblockID, const char *FileName ){

  int ChannelID = DENextFreeFile();

  DEFileOpenToRead( ChannelID, FileName );

  int FileSize = IDOS->GetFileSize( FileChannel[ ChannelID ] );

  DEMakeMemblock( MemblockID, FileSize );

  IDOS->FRead( FileChannel[ ChannelID ], DEGetMemblockPTR( MemblockID ), FileSize, 1 );

  DECloseFile( ChannelID );

 }

Concerning Open / Close, I get errors on compilations :

undefined reference to 'close'
undefined reference to 'open'

if I try to change this by :

if I change with IDOS->Open, I get warning :
PAssing argument 2 of 'IDOS->Close' makes integer from pointer without a cast ) ...
Arg 2 is not a pointer ... strange ?

Of course, I have <proto/dos.h> included ;)
and GetFileSize and FRead are correctly identified and does not report any error on compilation.

Don't mind .. I have checked the sample in AmigaOS 4 SDK and founded what was wrong :p

Kindest Regards,
Fred

All we have to decide is what to do with the time that is given to us.

Antique

Re: [FIXED] IDOS->Open / Close / FRead / GetFileSize

Posted on: 2009/10/7 0:08 #2

Home away from home

@freddix

You're welcome. Was just about to replay when i saw you're edit.

X5000

AmiDARK

Re: [FIXED] IDOS->Open / Close / FRead / GetFileSize

Posted on: 2009/10/7 0:17 #3

Quite a regular

@Antique
Loool :p

All we have to decide is what to do with the time that is given to us.

tboeckel

Re: [FIXED] IDOS->Open / Close / FRead / GetFileSize

Posted on: 2009/10/7 6:58 #4

Just popping in

@freddix

Quote:

FILE *FileChannel[ 256 ]; void DEFileOpenToRead( int ChannelID, const char *FileName ){ int FOpened = DEFileOpened( ChannelID ); if ( FOpened == 0 ){ if ( ChannelID > 0 ){ if ( ChannelID < 257 ){ FileChannel[ ChannelID ] = Open( FileName, MODE_OLDFILE ); } } } }

If you are using the DOS functions instead of the C library function the correct type for a file handle is BPTR instead of FILE*.

Furthermore you implemented the "zero index problem" at best. An array declared as "array[256]" has indices 0 to 255, but you check for 1 to 256. This will always leave the first entry unused (harmless) and write beyond the array bounds for the last entry (very harmful!!!).

Quote:

if I change with IDOS->Open, I get warning :
PAssing argument 2 of 'IDOS->Close' makes integer from pointer without a cast ) ...
Arg 2 is not a pointer ... strange ?

Not strange at all, given the fact that dos/Open() and dos/Close() use a BPTR variable, which in fact is a LONG and no real pointer.

AmiDARK

Re: [FIXED] IDOS->Open / Close / FRead / GetFileSize

Posted on: 2009/10/7 8:37 #5

Quite a regular

@tboeckel :
Yes, it's what I've seen and why I put it as "fixed" :p

All we have to decide is what to do with the time that is given to us.

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )