Login
Username:

Password:

Remember me



Lost Password?

Register now!
Sections
Who's Online
56 user(s) are online (42 user(s) are browsing Forums)

Members: 2
Guests: 54

kas1e, Kamelito, more...
Support us!
Recent OS4 Files
OS4Depot.net



« 1 2 3 4 (5)


Re: Odyssey 1.23: AOS4 source code on GitHub
Home away from home
Joined:
2007/9/11 12:31
From Russia
Posts: 6284
@Capehill
Quote:

Need to start fixing those compiler warnings, too ;)


Yes! There lot in gui code, i am sure fixing some of them will make some bugs disappear :) For example i don't like those warnings about all hooks. I.e.

Quote:

S/appclass.cpp:483:92: note: in definition of macro ‘REXXHOOK’
#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (HOOKFUNC)&Rexx, NULL, (APTR)(param) }
^~~~
/amiga/Odyssey/odyssey-r155188-1.23/Source/WebKit/OrigynWebBrowser/Api/MorphOS/appclass.cpp:483:92: warning: cast between incompatible function types from ‘LONG (*)(Hook*, Object*, IPTR*)’ {aka ‘long int (*)(Hook*, long unsigned int*, long unsigned int*)’} to ‘HOOKFUNC’ {aka ‘long unsigned int (*)()’} [-Wcast-function-type]


Probabaly some cast should be enough , but it will fix lot of warnings output, as it as for one hook it can bring up to 20 warnings where it used.

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Just can't stay away
Joined:
2007/7/14 21:30
From Lothric
Posts: 1026
@kas1e

Yeah, those hooks. It seems that C++ is more picky in function pointer casts than C. I have the same issue in some of my projects - (HOOKFUNC) gives warnings in C++. If someone has a solution, it would be nice to hear.

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Home away from home
Joined:
2007/9/11 12:31
From Russia
Posts: 6284
@Capehill
Another commit: this time remove dependency on libaos4deps.a (which contain stccpy() and DoSuperNew()), now i made them as one more object file, so no needs for custom libaos4deps.a anymore.

Next is probably we need to get rid of -lauto, just so things are cleaner ?

Quote:

Yeah, those hooks. It seems that C++ is more picky in function pointer casts than C. I have the same issue in some of my projects - (HOOKFUNC) gives warnings in C++. If someone has a solution, it would be nice to hear.


At least i found how to case to hide the warning, through do not know how correct is it. I.e. instead of:

Quote:

#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (HOOKFUNC)&Rexx, NULL, (APTR)(param) }


It's

Quote:

#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL },(HOOKFUNC)(LONG*)&Rexx, NULL, (APTR)(param) }


Warning gone then, links fine, but have doubts if it correct way and if all works at all as expected :)

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Just can't stay away
Joined:
2006/11/30 11:30
From Finland
Posts: 1736
@kas1e

Try replacing the "(HOOKFUNC)" cast with "(APTR)". This works for C code at least.

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Home away from home
Joined:
2007/9/11 12:31
From Russia
Posts: 6284
@salas00
APTR even bring not warning, but -fpermissive error:

Quote:

error: invalid conversion from ‘APTR’ {aka ‘void*’} to ‘uint32 (*)()’ {aka ‘long unsigned int (*)()’} [-fpermissive]
#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (APTR)&Rexx, NULL, (APTR)(param) }

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Just can't stay away
Joined:
2006/11/30 11:30
From Finland
Posts: 1736
@kas1e

In that case use "(HOOKFUNC)(APTR)&Rexx".

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Home away from home
Joined:
2007/9/11 12:31
From Russia
Posts: 6284
@Salas00
Yeah, that one works, thanks!

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Quite a regular
Joined:
2007/2/6 13:57
From Donostia (SPAIN)
Posts: 523
@kas1e

Did a new git clone (instead of a git pull) and recompile on my oooold dualcore intel machine, took some hours.
Everything went fine.
Just need to test build if it works ok on my SAM460ex

Great job guys!!!!

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Home away from home
Joined:
2007/9/11 12:31
From Russia
Posts: 6284
@All
SDK and main code were updated on GitHub, so if one wants to build it, an update of SDK must as well as minimum data files required now in the beta07 archive there: http://kas1e.mikendezign.com/aos4/ody ... odyssey_1.23r5_beta07.lha

   Report Go to top

Re: Odyssey 1.23: AOS4 source code on GitHub
Not too shy to talk
Joined:
2006/12/6 20:39
From California, Unitied States
Posts: 327
@kas1eQuote:
SDK and main code were updated on GitHub, so if one wants to build it, an update of SDK must as well as minimum data files required now in the beta07 archive

Thanks for the new release. Anything new besides blanking the mouse pointer while full screen videos are playing?

Never mind. Just found the answer in the "Odyssey 1.23 Progress" thread.
Thanks!

   Report Go to top


« 1 2 3 4 (5)



[Advanced Search]


Powered by XOOPS 2.0 © 2001-2016 The XOOPS Project