|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/17 16:22
#221 |
---|---|---|
Just can't stay away
![]() ![]() Joined:
2007/7/14 21:30 From Lothric
Posts: 1198
|
@LiveForIt
I'm not proposing to do both. Either manual OpenLibrary + GetInterface or -lauto. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/19 15:29
#222 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@Capehill
Is there example code somewhere? For an amigaos4 suitable solution...as easy as it can get, please |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 8:00
#223 |
---|---|---|
Just can't stay away
![]() ![]() Joined:
2007/7/14 21:30 From Lothric
Posts: 1198
|
@Raziel
Here is one example regarding manual opening of the asl.library: https://github.com/capehill/MilkyTrack ... iga/AslRequester.cpp#L110 Jabirulo made one too. I was fetching the latest ScummVM sources yesterday so I can try to assist, but I need your changes + new files. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 8:16
#224 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@Capehill
On it, thank you, i'll shout if/when i get stuck again |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 9:05
#225 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@Capehill
Could you help me to 1 - get rid of the warnings 2 - to use utf8 3 - polish (or rather fix) the code please especially utf8 is way beyond me Thank you These are the warnings and the utf8 error
C++ backends/dialogs/amigaos/amigaos-dialogs.o
and here is amigaos-dialogs.cpp
/* ScummVM - Graphic Adventure Engine
|
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 11:57
#226 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
Not sure but try this, and hope it removes some ASL warnings.
...
In case it warns about: extern struct Library *AslBase; extern struct AslIFace *IAsl; just comment them out. Edited by jabirulo on 2020/11/20 12:25:33
|
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 12:33
#227 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
I need to add i have no idea how to incorporate the utf8 stuff
backends/dialogs/amigaos/amigaos-dialogs.cpp: In member function 'virtual Common::DialogManager::DialogResult AmigaOSDialogManager::showFileBrowser(const Common::U32String&, Common::FSNode&, bool)':
|
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 18:49
#228 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
Maybe you need to put those definitions: extern struct Library *AslBase; extern struct AslIFace *IAsl; on top of amigaos-dialogs.cpp, before includes. BTW I forget to "NULLify" ASL variables at end: Exec->DropInterface((struct Interface*)IAsl); IAsl = NULL; IExec->CloseLibrary(AslBase); AslBase = NULL; |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 19:06
#229 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
Nope, still undefined refs on linking...the two extern structs are still inisde the if defined __amigaos4__
C++ backends/dialogs/amigaos/amigaos-dialogs.o
|
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 19:10
#230 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
Try tu put amigaos-dialogs.o as first file of linking objects. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 19:14
#231 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
That won't be as easy, the objects to link are hardcoded within the scummvm configuration. If i i change it once i'll have to change it everytime new code arrives... |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/20 19:18
#232 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
How is amigaos-dialogs.cpp added in the makefile (or whatever file makes the build)?
Can you see on your Shell/CLI/terminal the whole linking line/commandline? Maybe just copy&paste such linking line in a self made script and the you execute such script manually. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 13:11
#233 |
---|---|---|
Just can't stay away
![]() ![]() Joined:
2007/7/14 21:30 From Lothric
Posts: 1198
|
@Raziel
Don't use "extern". Also move Asl symbols outside the function to avoid "shadowing" warnings. In proto/asl.h symbols are declared as globals that's why compiler was worried.
struct Library* AslBase;
utf8ToLocal: as said you need to implement this function in the cpp. Check the corresponding MorphOS implementation. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 15:25
#234 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@Capehill
@jabirulo Boy, this compiler is picky ![]() I managed to move around stuff so i get it to build without warnings, thanks a lot for the help Now i'd like to implement the utf8 stuff (noob here aswell) but MorpHOS seems to use some stuff that is not available, or maybe i hvaenßt found it in the SDK (yet)? This is the codesets part i have in now
#if defined(__amigaos4__) && defined(USE_SYSDIALOGS)
But i get compiler errors and warnings...do i miss an include, maybe? Especially FSGetByteSize and ConvertTagList seem to be nowhere in my SDK. And what does that "expression cannot be used as function" mean?
C++ backends/dialogs/amigaos/amigaos-dialogs.o
Thanks for all the help guys, really appreciated...not that i'll learn much from it, but, yeah ![]() |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 15:52
#235 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
You need to add IFace: struct CodesetsIFace *ICodesets = NULL; ... ICodesets = GetInterface((struct Library *)(Codesetbase), "main", 1L, NULL); and close at exit/end: DropInterface( (struct Interface *)ICodesets ); ICodesets = NULL; ... Are those missing functions part of MorphOS/OtherOS? Or part of your port/sources? If part of MorphOS, check MorphOS sdk autodocs and see such functions and then try to amigaos4'ize thrm. EDIT: seems theyu a part of MorphOS charset autodoc: charsets.library/ConvertTagList() charsets.library/GetByteSize() Yo can try to adapt parts in convert.c example (codesets archive) and replace in your port/sources. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 16:10
#236 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
Thank you, funny it didn't warn me about those. Will try to find some info for FSGetByteSize and ConvertTags, thanks for the hints |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 16:46
#237 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
I think the missing ICodesets will shown only on linking stage. codesets has somethiong like "ConvertTagList": char *destbuf = CodesetsConvertStr( CSA_SourceCodeset, srcCodeset, CSA_DestCodeset, destCodeset, CSA_Source, buf, CSA_DestLenPtr, &destlen, TAG_DONE); You just need to "fill the gaps/variables" (convert.c example) |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 17:02
#238 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
That's what i thought too, but there were no linking errors. Anyway, i've placed these lines now, shouldn't hurt. "Filling in the gaps"...yes, but if you don't know the language you might get in trouble, just like with a gap text exam ![]() |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 18:15
#239 |
---|---|---|
Quite a regular
![]() ![]() Joined:
2007/2/6 13:57 From Donostia (SPAIN)
Posts: 589
|
@Raziel
ok, ok. I already used such function/method, will post it here ASAP and hope it will work for you. |
|
|
Re: Porting to AmigaOS4 thread |
Posted on: 2020/11/21 18:18
#240 |
---|---|---|
Home away from home
![]() ![]() Joined:
2006/11/26 21:45 From a dying planet
Posts: 3938
|
@jabirulo
Thank you, but it was not meant to throw the ball back to you. I was going fo look up those functions, just not right now ![]() |
|
_________________
People are dying. Entire ecosystems are collapsing. We are in the beginning of a mass extinction. And all you can talk about is money and fairytales of eternal economic growth. How dare you! – Greta Thunberg |
||