Who's Online |
52 user(s) are online ( 34 user(s) are browsing Forums)
Members: 1
Guests: 51
mdr,
more...
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/16 22:16
#41
|
Quite a regular 
Joined:
2007/2/6 13:57
Last Login
:
6/29 17:44
From Donostia (SPAIN)
Group:
Registered Users
|
@alfkil
Did a fast test and when quitting I get:
***¡Command 'KDH9:SDK/Spotless20220516' returned mising 'Disable'!
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/17 10:39
#42
|
Just can't stay away 
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabirulo And now? Spotless
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/17 13:47
#43
|
Quite a regular
Joined:
2007/2/6 13:57
Last Login
:
6/29 17:44
From Donostia (SPAIN)
Group:
Registered Users
|
@alfkil Same  #Devel:SDK/Spotless Hello. ***¡Command 'Devel:SDK/Spotless' returned missing 'Disable'!
...
int main() {
puts("Hello.\n");
struct DIPrefs test;
trial(&test);
return 0;
}#
Set BP in puts("Hel...) and trial(&test) got same (above) result when quitting.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/17 18:32
#44
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabirulo
Hmm. Strange. I am not sure, I can fix that without having a machine to run it.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/18 15:48
#45
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabiruolo
It is really strange, because I have commented out every call to Enable() and Disable(). I will need a working machine to test.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 11:53
#46
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabirulo
Just a quick question : Are you letting the child finish before exiting?
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 13:45
#47
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@kas1e Quote: EDIT: Also found GUI bug, to reproduce: -- run spotless -- hit RMB , choose "configure" -- see, on the left/top side, you have some empty small square appears and stay there since that time forever. Could you post a video or screenshot of this?
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 14:18
#48
|
Quite a regular
Joined:
2007/2/6 13:57
Last Login
:
6/29 17:44
From Donostia (SPAIN)
Group:
Registered Users
|
@alfkil I just put 2 BP, Start button (1st BP) and then "Step over" (I'm on 2nd BP) and I click close gadget, I don't let main() to finish (reach 'return 0').
int main() {
puts("Hello.\n"); // 1st BP
struct DIPrefs test;
trial(&test); // 2nd BP
return 0;
}
...
void trial(struct DIPrefs *diprefs) {
diprefs = 0;
return;
}
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 15:27
#49
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabirulo
Then that is the reason. If you don't let the child finish, there will be complaints from the system. I cannot change this. The only thing I could do would be to prevent you from quiting Spotless. And I don't want to do that.
So : The reason for the error is, that you have no way to force close a child in AmigaOS.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 15:36
#50
|
Quite a regular
Joined:
2007/2/6 13:57
Last Login
:
6/29 17:44
From Donostia (SPAIN)
Group:
Registered Users
|
@alfkil
Ok, without knowing Spotless (and system) internals, why Enable/Disable? Couldn't be changed to use Semaphore/Mutex and on quitting just "release"'em?
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 16:46
#51
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@jabirulo
In the last version you ran, there are no references in the code to Enable()/Disable(). So the relevant calls must be local to the system, or the error message is misleading.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 18:22
#52
|
Home away from home 
Joined:
2007/9/11 12:31
Last Login
:
6/22 18:37
From Russia
Group:
Registered Users
|
@alfkil Quote:
can you post a video or screenshot of it?
Sure, there is: https://youtu.be/hpnqyJLxINsSee, i just run congirue, and it reate some strange gadget at bottom left area of spotless window. This one never disappear and dunno what the purposes of it are. Feels like just GUI bug, imho.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/19 19:11
#53
|
Quite a regular
Joined:
2007/2/6 13:57
Last Login
:
6/29 17:44
From Donostia (SPAIN)
Group:
Registered Users
|
@alfkil
ok, thx for explanation.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
|
Just can't stay away
Joined:
2007/2/23 13:49
Last Login
:
5/20 0:40
From Finland, the land of Santa, sauna, sisu and salmiakki
Group:
Registered Users
|
Having a strange gadget on corners of a window means the program code is using a wrong variant of Set...Attrs functions or not passing the window pointer. Some gadgets require their own variants to work corretly like Clicktab and Virtual.
|
|
Rock lobster bit me, so excuse me.
X1000 + AmigaOS 4.1 FE
"Anyone can build a fast CPU. The trick is to build a fast system." - Seymour Cray
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 11:54
#55
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@TSK
Thanks!
@kas1e
Does the same problem appear with the MemorySurfer?
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 11:56
#56
|
Home away from home
Joined:
2007/9/11 12:31
Last Login
:
6/22 18:37
From Russia
Group:
Registered Users
|
@alfkil Quote:
Does the same problem appear with the MemorySurfer?
When i just click on memory surfer gadget ? No, all fine.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 13:35
#57
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@TSK and kas1e I have replaced
Layout *Layout::createLabeledLayout (string label) {
Layout *childLayout = new Layout(parent, label);
IIntuition->SetAttrs (layout,
LAYOUT_AddChild, childLayout->systemObject(),
TAG_DONE);
return childLayout;
}
with
Layout *Layout::createLabeledLayout (string label) {
Layout *childLayout = new Layout(parent, label);
IIntuition->SetGadgetAttrs (layout, parent->windowPointer(), 0,
LAYOUT_AddChild, childLayout->systemObject(),
TAG_DONE);
return childLayout;
}
Does this improve things? Spotless_SetGadgetAttrs
Edited by alfkil on 2022/5/20 16:03:19
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 15:17
#58
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@thread Sorry, found the bug. This one should fix it : Spotless_parent_fix
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 17:00
#59
|
Home away from home
Joined:
2007/9/11 12:31
Last Login
:
6/22 18:37
From Russia
Group:
Registered Users
|
@alfkil Quote:
Sorry, found the bug. This one should fix it :
Spotless_parent_fix
Tested. Cosmetic bug with "configure" in GUI gone. Also defaul FPR registers looks sane after loading. But i do find, that last entry in the registers are "trash", it show 0 and rectangle box. Like, you forget to terminate strings massive or something of that sort (maybe mislead \0 with just 0 or something). Also "Step out" crash bug i mention seems gone, but not sure if it reacts as expected , now that what i do: 1. run spotless 2. load or test case 3. hit bp on "puts" 4. once it breaks, hit "step out" At this point test case exit seems so, or something , but i do not have "Hello" in console.
|
|
|
|
|
|
Re: SpotLess tests need it to find out one bug
|
Posted on: 5/20 17:50
#60
|
Just can't stay away
Joined:
2009/10/7 1:11
Last Login
:
7/4 16:11
From Copenhagen
Group:
Registered Users
|
@kas1e Quote: But i do find, that last entry in the registers are "trash", it show 0 and rectangle box. Like, you forget to terminate strings massive or something of that sort (maybe mislead \0 with just 0 or something). Screenshot? EDIT : This is the responsible code :
result.push_back(printStringFormat("%" PRIu64 "\n", (uint64_t)context->fpscr));
I am not sure, if this is the correct way to print a 64-bit integer. I just copied it from some internet page. Does anyone have a good take on this? Quote: Also "Step out" crash bug i mention seems gone, but not sure if it reacts as expected , now that what i do:
1. run spotless
2. load or test case
3. hit bp on "puts"
4. once it breaks, hit "step out"
At this point test case exit seems so, or something , but i do not have "Hello" in console. Are you sure?? Hello should come in the shell window of the caller (where you ignite Spotless). In any case, try this and see if it helps : Spotless_isFunction_in_stepOut
Edited by alfkil on 2022/5/20 18:46:36
|
|
|
|
|
Currently Active Users Viewing This Thread:
1
(
0 members
and 1 Anonymous Users
)
|
|
|
|
News feed
OS4 Feedback forum
OS4Depot Feedback forum
Amigabounty forum
OpenAmiga forum
AmiCygnix forum
ABC shell forum
AmiKit forum
Cinnamon Writer forum
CodeBench forum
Digital Universe forum
Dopus 5 forum
E-UAE forum
Gnash forum
Ibrowse forum
JAmiga forum
Odyssey forum
OWB forum
Qt forum
SmartFileSystem forum
Timberwolf forum
TuneNet forum
Unsatisfactory Software forum
