TuneNet bug...

	Bottom Previous Topic Next Topic
Register To Post

spotUP

TuneNet bug...

Posted on: 2008/3/22 17:01 #1

Just can't stay away

TuneNet crashes on os4beta when using the skinned version, if i iconify it, and then when i uniconify it *boom!*

Raziel

Re: TuneNet bug...

Posted on: 2008/3/22 21:56 #2

Home away from home

@spotUP

Seems to be related with my skinned and docky bug

When i close TN it crashes

People are dying.
Entire ecosystems are collapsing.
We are in the beginning of a mass extinction.
And all you can talk about is money and fairytales of eternal economic growth.
How dare you!
– Greta Thunberg

Valiant

Re: TuneNet bug...

Posted on: 2008/4/7 4:53 #3

Not too shy to talk

@bean

While searching for the plugin that causes TuneNet to crash upon exit, I think I might have found another bug. If I have more then 25 plugins installed TuneNet puts up an Assign Requester with a bogus volume name when TuneNet starts up and when it exits. I can just simply cancel the requester and TuneNet works without any problems, but it is slightly annoying. Anybody else have more than 25 plugins installed and does it do the same?

Valiant@Camelot
AmigaOne XE, 800Mhz, 1GB, 9250 Radeon, OS4.1u7
Sam440ep, 666Mhz, 512Mb, 9250 Radeon, OS4.1u6
A1-X1000, 1.8Ghz, 1GB, 9250 Radeon, OS4.1x
A1-X5000/40 2.2Ghz, 2GB, Radeon HD 7700, OS4.1 FE ud 2

Raziel

Re: TuneNet bug...

Posted on: 2008/4/7 8:23 #4

Home away from home

@Valiant

I have 40 installed and don't get this behaviour, seems to
be a single plugin which causes it

salass00

Re: TuneNet bug...

Posted on: 2008/4/7 10:38 #5

Just can't stay away

@Valiant

I have 36 here (no assign requester and no crash on exit):
Quote:

Directory "Plugins" on Monday 07-Apr-08
TN_GBR.tnplug 7879 ----rwed 28-Mar-08 11:18:44
TN_SHN.tnplug 12806 ----rwed 30-Nov-07 12:47:15
TN_AdPlug.tnplug 9285 ----rwed 17-Mar-08 15:02:58
TN_WAVE.tnplug 44448 ----rwed 20-Nov-07 19:51:53
TN_AU.tnplug 18196 ----rwed 21-Nov-07 17:41:13
TN_YMAmp.tnplug 7938 ----rwed 26-Mar-08 15:32:45
TN_SSF.tnplug 8167 ----rwed 17-Dec-07 17:44:29
TN_TFMX.tnplug 113609 ----rwed 02-May-06 10:09:33
TN_SID.tnplug 926884 ----rwed 08-Dec-06 22:55:58
TN_SC68.tnplug 7555 ----rwed 27-Nov-07 18:56:00
TN_SAA.tnplug 331485 ----rwed 19-Mar-08 14:19:22
TN_RA.tnplug 119935 ----rwed 21-Nov-07 12:05:37
TN_QSF.tnplug 8315 ----rwed 17-Dec-07 18:19:58
TN_PT.tnplug 26776 ----rwed 15-Oct-07 16:47:38
TN_PSG.tnplug 8204 ----rwed 26-Mar-08 23:34:08
TN_PSF2.tnplug 8711 ----rwed 15-Jan-08 14:35:08
TN_PSF.tnplug 8815 ----rwed 29-Nov-07 18:14:28
TN_DSF.tnplug 8315 ----rwed 11-Mar-08 22:30:24
TN_S98.tnplug 468067 ----rwed 26-Nov-07 22:46:48
TN_WSR.tnplug 7207 ----rwed 28-Mar-08 13:00:10
TN_BS.tnplug 8026 ----rwed 03-Dec-07 12:15:50
TN_TFM.tnplug 33563 ----rwed 18-Mar-08 17:55:20
TN_AIFF.tnplug 8004 ----rwed 15-Oct-07 16:47:38
TN_AHX.tnplug 17154 ----rwed 02-May-06 10:09:34
TN_AAC.tnplug 82244 ----rwed 08-Dec-06 23:05:04
TN_2SF.tnplug 7930 ----rwed 11-Mar-08 15:11:20
TN_ACM.tnplug 34584 ----rwed 02-Dec-07 21:46:12
TN_GSF.tnplug 8847 ----rwed 29-Nov-07 18:13:39
TN_FLAC.tnplug 258272 ----rwed 08-Dec-06 22:58:14
TN_FC.tnplug 28715 ----rwed 02-May-06 10:09:34
TN_DT.tnplug 8013 ----rwed 28-Dec-06 19:09:26
TN_Cube.tnplug 715522 ----rwed 29-Nov-07 15:05:05
TN_OGG.tnplug 309744 ----rwed 10-Dec-06 01:25:46
TN_MSXPlug.tnplug 159603 ----rwed 26-Mar-08 19:33:56
TN_MP3_Encode.tnplug 496240 ----rwed 10-Dec-06 01:17:50
TN_MP.tnplug 478898 ----rwed 02-May-06 10:09:34
36 files - 4695K bytes - 9447 blocks used

I am using the experimental skinned version of TuneNet.

bean

Re: TuneNet bug...

Posted on: 2008/4/9 0:02 #6

Not too shy to talk

@salass00

I didn't realise there were so many plugin's available. I'll check the code as I thought I'd put a limitation in there. Looks like that limit code isn't working and it's trashing the place.

The plugin pointers are held within a static array and not a linked list, and there should be a limit. I'll make sure that limit goes up (64 be enough?) and that the limiter check works.

Cheers,
Bean.

OS4.1 + an A1XE with an appetite for batteries!

bean

Re: TuneNet bug...

Posted on: 2008/4/9 0:25 #7

Not too shy to talk

@bean

Whoops. Only 24 plugins are allowed, and the check code is messed up. Sorry all! Anything over 24 players will start to corrupt memory, please remove some players for the time being.

I'll get a service release out as soon as possible.

Bean.

OS4.1 + an A1XE with an appetite for batteries!

bean

Re: TuneNet bug...

Posted on: 2008/4/9 1:53 #8

Not too shy to talk

@bean

OK, Service release in OS4 Depot queue, which fixes the bugs mentioned above.

The next full version will have newer features.

Cheers,
Bean.

OS4.1 + an A1XE with an appetite for batteries!

spotUP

Re: TuneNet bug...

Posted on: 2008/4/9 2:24 #9

Just can't stay away

Download me now people!

Valiant

Re: TuneNet bug...

Posted on: 2008/4/9 2:57 #10

Not too shy to talk

@bean

Thanks, Bean, for the very quick service. Can't wait for the next full release!

Raziel

Re: TuneNet bug...

Posted on: 2008/4/9 8:33 #11

Home away from home

@bean

-The "Aweb retrieve" bug is back again and it annoys a lot

-Installing a 32nd plugin, opening and closing TN without
playing a song results in a crash with whatever plugin i
install - crashlog

-I get a "An error occured whilst loading the skin"
requester on every try to load skins, with every skin i
tried.

Thanks for the hotfix, at least those requesters asking for
funny assigns/partitions are gone now

bean

Re: TuneNet bug...

Posted on: 2008/4/9 9:47 #12

Not too shy to talk

@Raziel

Typing on a mobile device so this will be short!
Skins : Have you installed the expat library? See TuneNet site downloads for details. If so try one of the example skins ( lights ) that definately works.

Aweb : Can you describe fully?

Plugins : I'll check the crashlog when I can get to an Amiga?

Cheers,
Bean

OS4.1 + an A1XE with an appetite for batteries!

salass00

Re: TuneNet bug...

Posted on: 2008/4/9 10:04 #13

Just can't stay away

@bean

64 would probably be enough for time being, though 128 would probably be safer.

IMHO it would be better to use a linked list unless TuneNet does a lot of indexed lookups as this is slower. Exec linked lists are quite easy to handle using exec.library functions. There are also functions for doing name lookups (Find(I)Name) as well as sorting by priority (Enqueue). I use both of these features for the plugin interface in diskimage.device.

If it does use lots of indexed look ups then a solution would be to dynamically allocate the array and simply allocate a bigger array (about two times the old one's size would probably be good) if it finds more plugins and copy over everything from the old one before freeing it.

In either case there wouldn't be a hardcoded limit on the number of plugins.

bean

Re: TuneNet bug...

Posted on: 2008/4/9 10:16 #14

Not too shy to talk

@salass00

The system now correctly truncates to the max number of players (64). I will make this dynamic on the future, the playlist, radio list and other things all use lists (actually a mini DB class I wrote). I was just a bit lazy in the plugin department! :) I will follow up your suggestion.

Cheers Bean

OS4.1 + an A1XE with an appetite for batteries!

bean

Re: TuneNet bug...

Posted on: 2008/4/9 11:37 #15

Not too shy to talk

@Raziel

The crashog supplied suggests that a the save playlist is failing, specifically a file write. I'm wondering if a plugin is the cause of it (memory / file system errors). It's possible that a clean up on one of the plugins is not cleaning itself up properly.. Maybe, it cleans something up from TestPlayer() that is never used when you don't open a song??

Can you:

a/ check all plugins are up to date and reboot.

b/ Clear down to 0 plugins and launch / quit.

c/ Add a plugin, and keep doing step c until the problem occurs then note which 2 plugins were last added.

Thanks,
Bean

OS4.1 + an A1XE with an appetite for batteries!

Raziel

Re: TuneNet bug...

Posted on: 2008/4/9 15:13 #16

Home away from home

@bean

Quote:

Aweb : Can you describe fully?

Without TuneNet, everything is fine
as soon as TuneNet was started and fully closed again, AWeb
will start crashing with "AWeb retrieve task".
Further investigation of the crashlog reveals not much to me,
maybe you see something interesting?

Problem is it's crashing permanently once it has started,
one can "Ignore" but it will be 100% sure to pop up again
on the next site access.

We had this crash before, there is a thread on Amigans.net
already, unfortunately we thought it fixed back then...
probably a plugin related issue too?

Raziel

Re: TuneNet bug...

Posted on: 2008/4/9 16:09 #17

Home away from home

@bean

Quote:

Skins : Have you installed the expat library? See TuneNet site downloads for details. If so try one of the example skins ( lights ) that definately works.

I had an old expat.lib installed (v4.3 from i don't know
where) instead of OS4depot.net's 2.3
(It IS hard to keep up to date with those versions around)

Ash on my head, sorry for the hazzle on this one

Quote:

Can you:

a/ check all plugins are up to date and reboot.

b/ Clear down to 0 plugins and launch / quit.

c/ Add a plugin, and keep doing step c until the problem occurs then note which 2 plugins were last added.

a/ Everything up-to-date, not one old version around, i even
found one (MSX) which i hadn't before

b/ Done - no crash AND no AWeb oddities (!)

c/ Done - no crash upto 32 plugins AND no AWeb oddities
either. BUT with adding a 33rd plugin i get AWeb's bad
behaviour again, still no crash though.

...testing on

OK, heres the resumee, i got ZERO crashes on quit, need to
test further as this was no real life(tm) case, but it seems
it could have been my old expat.lib(?)

PS: It's great to have you back

Edited by Raziel on 2008/4/9 16:29:57

salass00

Re: TuneNet bug...

Posted on: 2008/4/9 21:55 #18

Just can't stay away

@Raziel

I have done some testing and for me the AWeb crash you describe happens if and only if the System GUI is enabled (I usually have it disabled and use the SkinFX GUI only). I'm thinking it may be related to the internet radio stations but I'm not sure.

Raziel

Re: TuneNet bug...

Posted on: 2008/4/9 23:50 #19

Home away from home

@salass00

Ah, yes, thanks for the in depth test.

Yes, i am quite sure it has to do with the radio stations,
maybe even only with the lists of the stations.
It seem to grab the list online and there does something
funny ... together with the System GUI it makes AWeb freak out.

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )