Yes you can change the buttons that are already recognized in the GUI

however on the command line it accepts .sfc/smc, do you want me to add the search for .sfc/smc in the graphical interface

You're modifying nw-Title and not restoring it, this will likely break window title.

Why are you opening DOS.library separately in _start instead of calling init

but that's not required anyway: all libraries opened in init() are kickstart libraries which can't fail to open. If any of them couldn't be opened loading the wb2filer executable wouldn't be possible either...

-- better parsing of the titles to handle spaces

-- better parsing of the Filer's path, which also may contain spaces

-- Added "static inline" in front of all functions (except _start and original functions) to reduce size of the binary even more.

Thanks joerg for all the points about!

You are searching for the first instead of the last '%', try something like

To reduce code size add "static inline" to all functions, except for _start().

Wb2filer doesn't work correctly for Usb media with space in its name. For example, when I try to open a USB msd with "No name" as volume name then I get a popup asking me to insert volume "No:"

Search for the last '%' (to make volume names with a '%' in it work, there might be file systems which allow such volume names) in the title. If none found, goto end:
From the position of the last '%' go back one by one char until you find a space. If there is none, goto end:
If the char before the found space is not an additional space, goto end:
Volume name = Fist chars until, but excluding, the 2nd space found + ':'.

Maybe some can also answer me a question about filer itself. What is the purpose of the SOURCE and DESTINATION. How do you use it as source or destination?

In the description of the OS4Depot archive, you should mention, that Filer is required and provide a link. Since this is not part of AmigaOS 4.

WB2Filer is a hack which patch Intuition's functions via SetMethod() to allow transparently run of the Filer binary pointing to the given partition on Workbench's
Desktop instead of original Workbench windows.

-- code cleaning based on Joergs suggestions, thanks!
-- first os4depot release

-- fixed NULL pointer crash when we deselect WB Backdrop from the Workbench's menu and select it back by adding null pointer check on the nw->Title (which are NULL for pure NewWindow->Title when we back from)

-- replaced usage of C lib malloc and I/O based functions, incl. functions like strdup(), asnprintf(), etc., in the patched functions to AmigaOS4 native ones. Because patched functions running in foreign tasks may not have called the required C library setup to be able to use such functions in a thread safe way. Thanks to Joerg for pointing out on !

-- get rid of -lauto and open/close all the libraries manually

-- ditched completely newlib's startup code, and going true Amiga way:_start() instead of main(),obtaining of exec manually, etc. For such a hack where size and bloat are matter, this is the way to go.

-- replaced every C function on the Amiga native ones from dos, utility, intuition, and exec libraries.

-- switched to Amiga way of parsing argv/argc via ReadArgs()

-- binary builds now without "ld", just "gcc -S" to build assembler output, and then by "as" to build from assembler a ready binary.

-- all the above points reduced the size of binary even more (now it's 6kb only)

You can use simple C library string functions like strlen(), str(i)cmp(), strstr(), etc., just not string function which allocate memory (strdup(), asnprintf(), etc.).

Remove usage of malloc and I/O based functions, incl. functions like strdup(), asnprintf(), etc., in the patched functions.

IUtility->SNPrintf().

For allocating memory only use IExec->AllocVecTags()/FreeVec()

Now that selList is gone and you don't need to free it at the end and just call Original_OpenWindowTagList(Self, nw, tagList) on error, you could get rid of the ok flag as well and write out return Original_OpenWindowTagList(Self, nw, tagList); everywhere. If you want to keep the flag and goto in case some clean up will be necessary in the future then use it consistently so also here should be goto end then:
if (strcmp(Caller->tc_Node.ln_Name, node->ln_Name) != 0) {
return Original_OpenWindowTagList(Self, nw, tagList);
}

you're probably modifying the window title with this;

At the beginning, checks are mixed up again, should be:
if (!nw || !(nw->Flags & WFLG_WBENCHWINDOW)) goto end;
struct Task *Caller = (struct Task *)IExec->FindTask(NULL);
if (!Caller || stricmp(Caller->tc_Node.ln_Name, "Workbench") != 0) goto end;
(or you can write it all in one line if you don't care about avoiding a call to FindTask when not needed or if you need to check Caller before window attributes).

- The skip_AsyncWB may have same problem as suppressing next beep but unlike that it may cause problems here. What happens if you run multiple wbrun commands e.g. from a script at the same time or quickly one after the other? Is there a better way to identify call after AsyncWB?

Just noticed: When WB2Filer is running, switching the Workbench background from a backdrop window to a regular window and then back again causes a crash (a DSI in the OpenWindowTagList() patch). Perhaps because there's no window title?

v.07 (14.12.2023)

-- totaly rewrote logic of patch: now instead of WB's WorkbenchControl() and manual icon selection,we simply based on window title names. This simplify patch a lot and make it work much better in all situations (thanks Joerg)

-- get rid of WFLG_BACKDROP check as struct *NewWindow never had WFLG_BACKDROP (joerg)

-- code cleaning by Balaton's suggestions (simplify DISK icon check, remove some nested ifs and indentation for readability, vars renaming, simplification of code, etc.)

-- added check on ActiveWindow to distinguish between main desktop and other windows more when want to have original Workbench windows while run wbrun from shell or from Filer's "Open Workbench"

-- added check on "Amiga+e" window (AsynWB - texinput process) : so when we hit "Amiga+e" we are able to do "wbrun" from it to have Original WB window.

-- rewrote README and made another version in true amiga.guide format

-- cosmetic fixes for the icons (thanks msteed for note)

You are checking the wrong one again
If NewWindow->Title

Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = RAM Disk 100% full, 0B free, 47.9KB in use
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = sfs2 63% full, 6,252.1MB free, 10.3GB in use
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = Work 38% full, 310.8GB free, 189.9GB in use
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = Public 1% full, 37.2GB free, 288.7MB in use
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = System 1% full, 198.3GB free, 2,237.3MB in use
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
nw->Title = morphos 0% full, 12.5GB free, 3,295KB in use

Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
ActiveWindow->Title = (null)
ActiveWindow->node->ln_Name = Workbench
WFLG_BACKDROP!

Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
ActiveWindow->Title = (null)
ActiveWindow->node->ln_Name = Workbench
WFLG_BACKDROP!
Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
ActiveWindow->Title = RAM Disk 100% full, 0B free, 47.9KB in use
ActiveWindow->node->ln_Name = Workbench

To check if something was called from the Workbench backdrop window you'd have to use (ActiveWindow->Flags & WFLG_BACKDROP) instead.

Task->tc_Node.ln_Name is AsyncWB - textinput process
NW is NULL

Task->tc_Node.ln_Name is Workbench
It's WBENCHWINDOW
ActiveWindow->node->ln_Name = Workbench
WFLG_BACKDROP!