@LiveForIt

Just fired up the SDL version of E-UAE 1.0.0, and I noticed that SDL is using 32bit BGRA.

The same color order the hack used you before you removed it.

Maybe BGRA is really the correct order...

@LiveForIt

As I said, throwing errors for multiple declarations of variable is a new feature of GCC 10 and above. Older versions silently assumed that the other instances should be extern.

Please see https://gcc.gnu.org/gcc-10/porting_to.html (-fno-common).

Not sure what you meant with your comment regarding GCC10. SDK 54.16 contains multiple GCC versions, including GCC 10.3.0 and GCC 11.2.0.

@LiveForIt

In your commit "Some palette functions moved to video_palette.c" you added the array uint32 load32_p96_table to the file gfx-amigaos/video_palette.c

This breaks compilation on gcc10 and higher.

I am not sure how to fix it. It depends on whether the variable in video_palette.c and ami-win.c should be the same instance or not. Right now, gcc less than version 10 treat them as the same.
If this is the wanted behavior, we just have to add an extern to one of the two declarations.

If the variables should be different in both files then we have to rename one instance.

@kas1e

Still, Picasso96 3.3.1 works better than 2.0.

It might be that there are some hacks in Picasso96 2.0 that need hacks in UAE to work...

Mmh,

The Picasso96 version has an influence on this issue. I updated the Picosso96 version on my AmigaOS 3.2.1 installation from 2.0 (Aminet) to the latest 3.3.1 (Icomp).

The Palette issue and wrong icon colors went away. But the icons lose their color after some screen updates with JIT activated. Without JIT, everything is fine:
- Colors are correct
- Splash screen has correct colors
- Icons do not loose colors

It is just slow.

Edit:
Screenshot with missing icon colors

Some pictures:

After opening Palette:
https://1drv.ms/u/s!ApOoV0ole8uGrddKPv3C2fagEHqAJg?e=GP092Z

Selecting color 4:
https://1drv.ms/u/s!ApOoV0ole8uGrddJcy3PV9bPJdMOng?e=1uW2Yy

Selecting color 5:
https://1drv.ms/u/s!ApOoV0ole8uGrddHhki9zxNeRnGbBA?e=vgXRqa

This is using A8R8G8B8.

@LiveForIt

No, sadly not.

But I noticed something strange: After opening Prefs->Palette, the icon colors are somewhat fixed. If the icons are redrawn, the colors are mostly correct. It does not fix the splash screen, though.

Additionally, selecting any of the upper four colors (used by icons, not WB), the color is replaced by the wrong (blueish or redish) version. Selecting another color fixes the previously selected one, but now the next one is wrong.

@LiveForIt

Not sure if that helps, but I compile uae on my X5000.

And I updated the binary to the latest version. If I use Windows to copy the file, I do not need to recreate the link.

@kas1e

I manually edited src/gfx-amigaos/ami-win.c and changed the lines. The patch is not in the repo yet.

@Skateman

No, it is not.

@Skateman

Thanks. Hopefully, this works now:
https://1drv.ms/u/s!ApOoV0ole8uGrdccqZANTe6RLmp-1Q?e=SxCtP8

@white

It seems I must create a new link every time I update the version :(

The current beta is here: https://1drv.ms/u/s!ApOoV0ole8uGp-hrpmbqp-RTVE-PbA?e=gFZymX

@white

You will find my compiled version on my personal OneDrive. Please see this post for the link:
Post with link to compiled version

@LiveForIt

I applied your changes to my sources and recompiled uae.

Yes, this fixes the "blue" tint on icons (Amiga OS 3.2.1) and the splash screen (3.2.1 and 3.9).

Not sure if this related to the color format change, or if this is due to your other change today, but the screen drawing is much slower now.

Edit:
Yes, using RGBFB_B8G8R8A8 instead of RGBFB_A8R8G8B8 is much slower.

I have the blue tint on icons and some images (StormC splash screen) on AmigaOS 3.2.1 on 32bit modes using RadeonHD 3.7 and 5.14 (Radeon R7 250).

Edit:
The icons are okay on AmigaOS 3.9, but the StormC splash screen has the same wrong colors as under AmigaOS 3.2.1.

So, not only icons are affected, and it happens on different AmigaOS versions.

@LiveForIt

Your latest changes broke the icon colors in 32bit/32bit mode:
Icon Color issue

@LiveForIt

Thank you, with the latest version I did not encounter the slowdown issue yet. But this versions seems to be a bit slower than the previous one. But it is still okay on 1920x1080x8bit.

And I am using TuneNet, WookieChat, IBrowse and Odyssey in parallel. With the old version the issue triggered even without using any of these programs.

I am testing with X5000 and OS4.1 FE Update 2 (Kickstart 54.30, Workbench 53.18).

Update:
The version on OneDrive is the latest one now.

@LiveForIt

Not sure, if it is caused by more aggressive/intense calculations, uae should be slow from the start, and the performance should not drop suddenly after some time.

Also, this would not explain why a thread keeps running after I quit uae using "CRTL + ALT + Q".

Thanks for the new changes. But they did not help; if at all they made the issue trigger faster for me. With the new binary the slowdown happened after a minute or so with just loading and compiling one example in StormC.

Before, it was quite hard to trigger the issue.

BTW: You can download the new binary from OneDrive. The object behind the link is updated.

Okay, now I had also your issue. Opening and closing drawers, changing the background, and finally doing a reset triggered it.

OS 4.1 got very slow until I quitted e-uae. And then I got the popup that some parts of uae are still running.