Thanks for the fast update

@Tom
That one fixed all my problems with dirs loading, thanks !

@Tom

But found another problem. Something weird start to happens with the playback/stop routines of mp3 in the latest versions(i note it even in previous ones, just wasn't able to reroduce normally, but now i can show proper test case).

I do all tests on debug.kernel with munge enabled on peg2 latest os4beta. So there is test case:

1. hard reboot
2. run amigaamp
3. open any mp3 : it start plays.
4. wait a little and open another mp3: some time it start plays, sometime crash. If it start to play, then press "stop" after a while , and then crash anyway. Sometime its even able to play 3-4 files, and you can press "play" and "stop" buttons, but anyway pretty soon it crashes.

Crash always in the AmigaAmp PlayTaks. Crashlog : http://kas1e.mikendezign.com/temp/aamp_crash.txt

Ignore DSI leads to bunch of memory trashing:

Quote:

@Tom

Using the latest 3.12 I got a curious regression about the new auto depth-arrange feature, as you can see on the grab below i just placed AmigaAMP very closed to an another window, then i pressed many time the play/pause buttons .. after a while the Main area part of AmigaAMP will be showed above all !

http://s21.postimg.org/b5ljbgep3/amigaamp.png

P.S.
For the next release it would be cool if you can (optionally) reactivate the good old "window-followed" behaviour effect

@kas1e

Yes, I had it play "many" files, but then I needed to stop before going on to the next one. Pressing next/play made it crash (I had two by now with build #209).

@kas1e
I had that problem as well. I would load a file, then play, and load a different file and would get a crash.

I re-installed OS4.1 and all the updates, then the problem was gone. I can load a file, play it, load other songs and they start to play automatically with no problem.

I wonder if there is some other software or libraries I had installed that was causing the problem.

@kas1e

Are you sure you haven't a tunenet plugin installed that is crashing?

I have no TN plugins (or the accompanying data directory) and it's the same crash.

@raziel
all tests done on stock version, problems starts in latest 2 versions if i remember right. if it works for you it can be same luck as with dirs loading (also works for you before, but bug was here). i assume its about that major players code rewrite which Tom do few versions ago.

Hmm, the crash occurs directly after an AHI SendIO() call in AmigaAMP.

I've changed the code to use AllocSysObject() now instead of CreateIORequest() in all AHI routines.

Do you have "Keep AHI open" turned on in AmigaAMP-Prefs? If no, please try turning it on to see if it makes a difference.

@Tom
Quote:

By default was "off" for me, so once i turnted it "on" no more crash.

But sadly to say bug with loading of directories still there :( Now its just can play 2 first files (instead of only 1 as in previous version). I.e. i have directory "test" in which i have 1.mp3 in the root, and 4 mp3s in the another "lala" directory, i.e. layout is:

work:music/test/1.mp3
work:music/test/lala/a.mp3
work:music/test/lala/b.mp3
work:music/test/lala/c.mp3
work:music/test/lala/d.mp3
work:music/test/lala/e.mp3


So, if i just choice "test", it load to playlist all of them, but i can play only first 2 files (test/1.mp3 and test/lala/a.mp3) all others can't be clicked/played.

Hmm, I can't reproduce that at the moment. Can you contact me via email, please, so we can debug this together? :)

@kas1e

I just tried your exact condition

made a dir called "test", inside a dir called "lala".
Put an mp3 in test and four mp3's in lala

Works as it should.

I can let AmigaAmp play through all these files
I can click on all the files in the playlist and they play
I can choose the first track and click on "next song"

All works

Just to rule out a prefs problem, my prefs are

Tab "Program"
"Multiple Instances" NOT checked
"Playlist"
Double Click - Load and Plays File
Save Format - Plain List
Scan Method - Scan Time in Background
"Playback and Information"
(I have only the following checked)
Autoplay File
Read ID3 Tag

Leaving out Tab "GUI"

Tab "Audio"
Leaving out "DSP"

"AHI"
Unit 0
Keep AHI Unit Open

Tab "System"
"Buffers"
Loading - 256 KB
Playback - 1 s
Asynchronous Loading - Checked
"Priorities"
Main - 5
Playback - 10
Visualization - 5


Try with those settings and see if your problem goes away

@Tom
I send you mail, check this out plz

@Raziel
I will debug it with Tom, but thanks for worry.

Ok, got it nailed down! Thanks to kas1e for debugging help!

It only happens when the file requester returns the selected directory as a filename.

In our case:
"Directory" is "work:music"
"Filename" is "test" <-- which is in fact another directory.

In this case a stupid bug in my code is triggered leading to a miscount of actually listed/loaded files.

I couldn't reproduce it because my normal ASL requester returns:

"Directory" is "work:music/test"
"Filename" is empty

The bug is also triggered when you try to open a mixture of directories and files using multi-select within the file requester.

I've fixed that now along with a wrong memory allocation call if a user attempts to load a directory with no files in it.

I've also fixed a bug causing weird AHI lockups when "Keep AHI open" is NOT ticked.

Guess meanwhile it's time for a 2.13 release.

Tom there is also a little bug into the cover functionality, on the information window sometime the cover will not be showed at all. or (if you still have the info window opened) it even will not be changed when a new song will be started !

Pls check it too

Damn, haven't been able to reproduce that either.

Any idea how to provoke it?

@Tom
One more moment :) : if i open an mp3 file, play it a bit , press stop button, and then press on "open" and in asl requester press "chancel", then, auto-play of mp3 which i load previously starts (while, imho, nothing should happens as we do nothing, just exit from asl requester).

@Tom

Not specifically, but more or less i can reproduce it as is:

1 - Just start AmigaAMP as is (with no music) --> now open the "Info" window --> You will see that the placeholder cover is displayed normally
2 - But now drag a music folder into AmigaAMP --> now recheck the "Info" --> now your placeholder cover are NOT displayed anymore and just a blank space will be showed

2a) Now staying at "point 2" i leaved the Info window opened and i start playing a song (that have a cover)
So just when the song started its specific cover will be correctly filled and displayed (so it fill the blank placehover area)

2b) But if i choose another song (that doesn't have any corrispondent cover) the cover of the previews song still displayed rathen then overwrited with the new cover (or with the placeholder) !

So here we have atleast 2 different bugs :-/


- Also another little bug still in Prefs and it seems related to the autoplay functionalities :-/

"Autoplay File" and "Autoplay List" is correctly ticked in my AmigaAMP-Prefs, but songs doesn't start automatically
I try with drag&drop and also opening musics file from the requester, but the functionality still don't work

So in total 3 little bugs atleast ..

Hmm, and sometimes it works and sometimes it doesn't with exactly the same files?

About the cover i don't know if is it random or not, but atleast i can always reproduce it with the step-by-step method i reported above.

If you need we can continue our discussion via mail so eventually I can provide some grabs or even my music folder for quick testing

@samo79

Doesn't happen here, both problems you described

@Raziel

The bug on the cover display was real, according to Tom it was a missing/uninitialized parameter calling DTM_PROCLAYOUT, but now it's fixed

Still to verify the AutoPlay problem, here this functionality doesn't work at all even using the latest 3.13 Beta